-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIREQ-1190 - Add "Retrieval service point" filter #1244
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terala-Priyanka
removed request for
a team,
Dmitriy-Litvinenko and
artem-blazhko
December 12, 2024 12:15
…so that 'Retrieval service point" filter is not available from deprecated folder path
…into UIREQ-1190
Terala-Priyanka
requested review from
artem-blazhko,
Dmitriy-Litvinenko and
a team
December 13, 2024 06:37
@artem-blazhko @folio-org/fe-tl-reviewers |
src/deprecated/RequestsFilters/PickupServicePointFilter/PickupServicePointFilter.js
Outdated
Show resolved
Hide resolved
src/deprecated/RequestsFilters/RequestLevelFilter/RequestLevelFilter.js
Outdated
Show resolved
Hide resolved
src/hooks/useRetrievalServicePoints/useRetrievalServicePoints.js
Outdated
Show resolved
Hide resolved
src/hooks/useRetrievalServicePoints/useRetrievalServicePoints.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Mariia Aloshyna <[email protected]>
…into UIREQ-1190
@mariia-aloshyna and @artem-blazhko Could you please re-review now? |
artem-blazhko
approved these changes
Dec 17, 2024
mariia-aloshyna
approved these changes
Dec 17, 2024
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
UIREQ-1190 - Add "Retrieval service point" filter in Request app.
Approach
This feature "Retrieval service point" is supposed to be delivered for LOC only, in the scope of Ramsons. Later from Sunflower onwards, it will be generally available. Hence existing
RequestsFilters
form master branch has been duplicated insrc/deprecated/components
folder. The is the reason that Sonar complains of high code duplication.New implementation of
Retrieval service points
filter will be available fromsrc/components/RequestsFilters
.With this approach,
Retrieval service points
filter is available only on environments where the flagenableEcsRequests
is enabled from stripes config.Another filter accordion is introduced to Request filters with name "Retrieval service points". It is a multi-selection filter.
A Retrieval service point is the primary SP of an item's effective location.
Hence, retrieval sps options are formed by
Refs
Screenshots
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.