Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIREQ-1190 - Add "Retrieval service point" filter #1244

Merged
merged 21 commits into from
Dec 17, 2024
Merged

Conversation

Terala-Priyanka
Copy link
Contributor

@Terala-Priyanka Terala-Priyanka commented Dec 10, 2024

Purpose

UIREQ-1190 - Add "Retrieval service point" filter in Request app.

Approach

This feature "Retrieval service point" is supposed to be delivered for LOC only, in the scope of Ramsons. Later from Sunflower onwards, it will be generally available. Hence existing RequestsFilters form master branch has been duplicated in src/deprecated/components folder. The is the reason that Sonar complains of high code duplication.

New implementation of Retrieval service points filter will be available from src/components/RequestsFilters.

With this approach, Retrieval service points filter is available only on environments where the flag enableEcsRequests is enabled from stripes config.

Another filter accordion is introduced to Request filters with name "Retrieval service points". It is a multi-selection filter.

A Retrieval service point is the primary SP of an item's effective location.
Hence, retrieval sps options are formed by

  1. collecting primary service point of each location of a tenant
  2. preparing options for retrieval service points filter from the above collection

Refs

Screenshots

chrome_13osu76egp

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@Terala-Priyanka Terala-Priyanka marked this pull request as draft December 10, 2024 10:30
@Terala-Priyanka Terala-Priyanka self-assigned this Dec 10, 2024
Copy link

github-actions bot commented Dec 10, 2024

Jest Unit Test Statistics

       1 files  ±  0       66 suites  +4   1m 54s ⏱️ +5s
   837 tests +  9     837 ✔️ +  9  0 💤 ±0  0 ±0 
1 195 runs  +61  1 195 ✔️ +61  0 💤 ±0  0 ±0 

Results for commit 0830ed7. ± Comparison against base commit 039a9ea.

♻️ This comment has been updated with latest results.

@Terala-Priyanka Terala-Priyanka marked this pull request as ready for review December 10, 2024 13:01
@Terala-Priyanka Terala-Priyanka requested review from artem-blazhko and a team December 12, 2024 07:24
@Terala-Priyanka Terala-Priyanka marked this pull request as draft December 12, 2024 12:14
…so that 'Retrieval service point" filter is not available from deprecated folder path
@Terala-Priyanka Terala-Priyanka marked this pull request as ready for review December 13, 2024 08:18
@Terala-Priyanka
Copy link
Contributor Author

@artem-blazhko @folio-org/fe-tl-reviewers
Please review this PR

@Terala-Priyanka
Copy link
Contributor Author

@mariia-aloshyna and @artem-blazhko Could you please re-review now?

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
45.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@Terala-Priyanka Terala-Priyanka merged commit dac2d58 into master Dec 17, 2024
4 of 5 checks passed
@Terala-Priyanka Terala-Priyanka deleted the UIREQ-1190 branch December 17, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants